CPython code review standards
E888279
CPython code review standards are the official guidelines that define how changes to the reference Python implementation are evaluated, discussed, and approved by core developers and contributors.
Statements (51)
| Predicate | Object |
|---|---|
| instanceOf |
project governance document
ⓘ
software development guideline ⓘ |
| aimsTo |
ensure code quality
ⓘ
ensure consistency across the codebase ⓘ make reviews predictable and fair ⓘ reduce bugs introduced by changes ⓘ |
| appliesTo |
CPython project
NERFINISHED
ⓘ
CPython reference implementation of Python ⓘ |
| definesProcessFor |
approving pull requests
ⓘ
discussing design changes ⓘ handling review comments ⓘ merging changes ⓘ reviewing code changes ⓘ |
| discourages |
large unrelated changes in a single pull request
ⓘ
style-only changes without justification ⓘ |
| documentedIn |
Python Developer Guide
NERFINISHED
ⓘ
devguide.python.org NERFINISHED ⓘ |
| encourages |
discussion on the issue tracker for controversial changes
ⓘ
multiple reviewers for complex changes ⓘ respectful and constructive review comments ⓘ small focused pull requests ⓘ use of GitHub pull requests ⓘ |
| governedBy | PEP process ⓘ |
| implementedOn | GitHub pull request workflow NERFINISHED ⓘ |
| includesPrinciple |
clear rationale for changes
ⓘ
cross-platform compatibility ⓘ maintainability of the codebase ⓘ performance awareness ⓘ readability of code ⓘ regression avoidance ⓘ security considerations ⓘ stability of public APIs ⓘ |
| maintainedBy |
Python Steering Council
NERFINISHED
ⓘ
Python core developers NERFINISHED ⓘ |
| relatedTo |
CPython commit privileges
NERFINISHED
ⓘ
CPython contribution guidelines NERFINISHED ⓘ CPython development workflow ⓘ Python Enhancement Proposals NERFINISHED ⓘ |
| requires |
adherence to PEP 7 for C code style
ⓘ
adherence to PEP 8 for Python code style ⓘ at least one core developer review for most changes ⓘ backwards compatibility considerations ⓘ clear commit messages ⓘ documentation updates when behavior changes ⓘ news entry for user-visible changes ⓘ reference to relevant issue numbers ⓘ tests for bug fixes ⓘ tests for new features ⓘ |
| usedBy |
CPython contributors
NERFINISHED
ⓘ
Python core developers NERFINISHED ⓘ Python triagers NERFINISHED ⓘ |
Referenced by (1)
Full triples — surface form annotated when it differs from this entity's canonical label.